So today I discovered that there’s a cron job that holds non-reproducible state that died, and now our system is fucked.

The cron job doesn’t live inside any source control. This morning it entered a terminal state, and because it overwrites its state there’s no way to revert it.

I’m currently waiting for the database rollback and have rewritten it in a reproducible/idempotent way.

  • JackbyDev@programming.dev
    link
    fedilink
    English
    arrow-up
    4
    ·
    2 days ago

    Had a similar thing once. Some how, some way, the DBA copied and pasted something wrong. Oracle DB had some odd extra syntax for left and right joins that other DBs didn’t (or at least that I’d never seen). My best guess is that he auto formatted out of habit and maybe it took those symbols out.

    It took a long time to find that. Because the only evidence something was wrong was that ONE of our customers wasn’t being billed for ONE product. Everyone else was fine. Basically they were using it in a very atypical way. The left joins made sure to include them in the billing even because they didn’t have whatever was on the right of that join. Everyone else did.

    • wise_pancake@lemmy.caOP
      link
      fedilink
      arrow-up
      2
      ·
      edit-2
      2 days ago

      SQL auto format is still mostly terrible

      The only half decent format is to start from the Mozilla style and then make it more sane.

      I’ve been playing with sqlglot lately and want to start using it for diffs.

  • wise_pancake@lemmy.caOP
    link
    fedilink
    arrow-up
    161
    ·
    4 days ago

    What’s extra frustrating is the previous guy did create a git repo of these types of hacks, but this one doesn’t live in it for no discernible reason.

      • wise_pancake@lemmy.caOP
        link
        fedilink
        arrow-up
        111
        ·
        4 days ago

        He does charge a consulting fee to “fix” these issues

        Almost all of them are dumb shit like this, where something is built in super hacky and dumbass ways.

          • Agent641@lemmy.world
            link
            fedilink
            arrow-up
            19
            ·
            3 days ago

            Judgement day postponed indefinitely due to “Object reference not set to an instance of an object”

            • kiagam@lemmy.world
              link
              fedilink
              arrow-up
              2
              ·
              3 days ago

              I don’t know why but this is the first time I read this phrase and it actually makes sense.

              I knew exactly what it meant before, but it didn’t make sense until now

            • Sherry@programming.dev
              link
              fedilink
              arrow-up
              4
              ·
              3 days ago

              that might be a stupid question, but why would you running all services in tmux be a bad idea? a co-worker of mine is doing exactly that right now, which is why I’m asking.

              • qaz@lemmy.world
                link
                fedilink
                English
                arrow-up
                2
                ·
                edit-2
                13 hours ago
                1. They’re all gone when you restart
                2. It doesn’t properly deal with logging
                3. You can’t set up dependencies between services but that doesn’t matter due to point 1

                I recommend using systemd services and/or docker compose instead. systemd services are files that describe which program / script to run and when (like after networking is active or after a certain other service is loaded).

              • swab148@lemm.ee
                link
                fedilink
                English
                arrow-up
                4
                ·
                3 days ago

                It’s not horrible, like it’ll do the job just fine, it’s just probably a better idea to use systemd and like, containers and whatnot, but I couldn’t be arsed to fiddle with all that for Jellyfin, caddy reverse proxy, and two modded Minecraft servers, so shell scripts and tmux won the day. It takes a little extra time to restart everything after an update, and maybe I’ll get the motivation to do things “correctly™” one day, but today is not that day.

      • koper@feddit.nl
        link
        fedilink
        arrow-up
        20
        ·
        4 days ago

        But the whole point of the doomsday machine is lost… if you keep it a secret! Why didn’t you tell the world, eh?

        • MyBrainHurts@lemmy.ca
          link
          fedilink
          English
          arrow-up
          10
          ·
          4 days ago

          It was going to be announced at his retirement party on Monday… You know the dev likes surprises.

  • MonkderVierte@lemmy.ml
    link
    fedilink
    arrow-up
    33
    ·
    edit-2
    3 days ago

    Only tangentially related, but “What a elegant house of cards” is an insult i’m going to use someday.

  • Korhaka@sopuli.xyz
    link
    fedilink
    English
    arrow-up
    3
    ·
    2 days ago

    For us it’s a task that no one is even aware of and the first issue is the customer saying their data export doesn’t work. You had a data export?

  • LainTrain@lemmy.dbzer0.com
    link
    fedilink
    arrow-up
    24
    ·
    3 days ago

    Cron job that evals some base64 encoded string which is actually downloading a script from a personal GitHub repo of an IT guy who left…

  • arotrios@lemmy.world
    link
    fedilink
    English
    arrow-up
    72
    ·
    edit-2
    4 days ago

    This is almost exactly what happened to me on Monday, resulting in a fifteen hour day.

    My particular jenga piece was an Access query that none of my predecessors had deigned to document or even tell me about… but was critical to run monthly or you had obsolete data embedded deep within multi-million dollar reports.

    Thank god I don’t work on salary anymore, or I’d be really upset.

  • Primer - Zip@lemmy.zip
    link
    fedilink
    English
    arrow-up
    24
    arrow-down
    1
    ·
    4 days ago

    Idempotent code/repositories are great - I love making everything as reproducible as possible. Particularly in make where every ‘all’ type command should have a corresponding ‘clean’ command. Many times I’ll see code bases where they skip defining the ‘clean’ command… or worse, have no ‘all’ command to begin with and rely on the developer knowing all the build and environment setup commands…

    • wise_pancake@lemmy.caOP
      link
      fedilink
      arrow-up
      21
      ·
      3 days ago

      Yeah, I don’t consider most code complete unless it’s safe and reproducible. I love make, currently using npm but you can set up scripts with it. Automating the build process was the very first thing I did.

      This project is a piece of work. There’s effectively no documentation, and every now and then I find something new like this. The stuff I’ve fixed up so far has been much much more reliable and performant.

      Part of me just wants to rewrite the whole thing, but I need to ship features so we can sell the product and pay my salary.

      At least I’m not a cog in a huge corporation getting my soul crushed every day. I actually love fixing weird stuff.

  • mesa@lemmy.world
    link
    fedilink
    English
    arrow-up
    18
    arrow-down
    1
    ·
    4 days ago

    We have a couple of those at work. Black boxes that are used.

    I’m rebuilding one after it failed on one morning for SQL odbc reasons. And its just a binary that shuffles data around.

  • Godort@lemm.ee
    link
    fedilink
    arrow-up
    13
    ·
    4 days ago

    Time to restore a whole machine backup to a VM with no network connectivity, and manually pull the command?